Skip to content

Conversation

@rajat2004
Copy link
Contributor

@rajat2004 rajat2004 commented Dec 6, 2019

which if the command is not present doesn't give empty string, instead says "not found"
Fixes the detection of required tools, plus sets the correct path of CMake on OSX

@rajat2004
Copy link
Contributor Author

Noticed while doing a fresh setup on Ubuntu 18.04 where default CMake version is 3.10.2

@rajat2004
Copy link
Contributor Author

The last commit just moves the block of code for finding the CMake binary since earlier, it was being executed only if the platform was Linux, thus disabling finding the binary on OSX

@madratman
Copy link
Contributor

really good catch. setup.sh is wasting a lot of unnecessary time in any machine which already has the up to date versions of these deps.

@madratman madratman merged commit c3fdb68 into microsoft:master Mar 23, 2020
@rajat2004 rajat2004 deleted the fix-setup-cmake branch April 2, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants