Fix some warnings

[rajat2004]

There are more warnings, many unused variables which can be seen when running the Unity build

Right now only testing till compilation

[rajat2004]

Should we remove the -Wno-unused flag here?

[saihv]

-Wno-unused is meant to ignore warnings involving unused variables, are you seeing those even with this flag on?

[rajat2004]

No, the warnings are coming from the Unity build where it hasn't been disabled
I'm not sure if we should disable them or not, I haven't yet fixed all the warnings

[saihv]

I would advise against removing variables, especially in complex libraries like MavlinkCom - while they may be unused in that particular piece of code, they could have been meant to exist for the purpose of extensibility or some sort of parity.

If a variable has a purpose and is named appropriately it does not detract from the code as a whole. Warnings are a smaller problem, and I recommend we handle it through compiler flags. My two cents

[rajat2004]

I agree, removing all the unused variables probably doesn't make much sense, that's why I haven't yet removed variables from places like AdaptiveController and some others in Mavlinkcom
Should I remove the commits for Mavlinkcom which are there right now?

[rajat2004]

Once the warnings which should be ignored and fixed are decided, then will clean up the commits
Also, the Unity cmake needs to be looked at, there shouldn't be 2 sets of build flags, etc.

I'll go through the Mavlinkcom commits and only remove variables which seem harmless, or don't have any meaning currently

[rajat2004]

I think I'll add back the other variables in Mavlinkcom but remove the ones commented above if others agree

[rajat2004]

Commits cleaned up, only removed variables which didn't fit in the context

[rajat2004]

I'm not sure if this is correct or not, we should probably set the goal in this case also

[madratman]

/azp run microsoft.AirSim

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).