Extend Recording to multiple vehicles #2847
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Additions -
VehicleName),VehicleNameparameter inCamerasfield to specify specfic vehcile to use the camera fromFolderfield in settings to change the directory to store data inExample settings -
Recording - 2020-07-11-11-48-51.zip
Testing -
TODO:
Further possible additions -
Documents)- I suspect this might be a race condition for the first write, since there are no images, no rendering and saving of images is required, so writing of pose data is happening almost instantaneously, but the file to write the data in hasn't still been created.(Haven't confirmed this though, just a thought)
Any testing (especially of
Folderon Windows) or suggestions would be great!Came to mind when working on #2841
Related older issue #1346, Also includes the fix proposed in #1414