Skip to content

Add support for Distance Sensor in ArduPilot#2920

Closed
rajat2004 wants to merge 4 commits intomicrosoft:masterfrom
rajat2004:ap-distance-sensor
Closed

Add support for Distance Sensor in ArduPilot#2920
rajat2004 wants to merge 4 commits intomicrosoft:masterfrom
rajat2004:ap-distance-sensor

Conversation

@rajat2004
Copy link
Contributor

@rajat2004 rajat2004 commented Aug 7, 2020

Changes -

  1. Support for Distance Sensor in ArduPilot, also increase RC channels to 12
  2. Fix style inconsistency, use unique_ptr in ArduPilot files
  3. Unity: Update to C++14 standard

Win Blocks binary - https://drive.google.com/file/d/1eLaC58nnh0ms9BhHqvVMnXo9o_xiH3pr/view?usp=sharing

TODO:

Corresponding AP PR - ArduPilot/ardupilot#15007
Follow-up after #2807

Code duplication, any ideas on how this can be reduced?

Second-last commit fixes a style inconsistency, camel case is not used for variables there, also no idea why I used shared_ptr, maybe a remanent of earlier copy-paste from PX4 backend.
Last one updates C++ standard used in Unity to C++14, required for make_unique (see https://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique), otherwise this happens

However, AirLib is built with C++17 standard in UE, which can cause problems later on. Should it be updated further to 17? (Tested it to be working locally)

@rajat2004
Copy link
Contributor Author

rajat2004 commented Sep 1, 2020

@madratman @saihv @ironclownfish @jonyMarino Just asking, would it be possible to have the packaged Blocks binary from the Azure Pipelines available to download? Described here https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/artifacts-overview?view=azure-devops (I haven't myself gone through it completely)
Also mentioned here - #2866 (comment)

@rajat2004
Copy link
Contributor Author

@madratman @saihv @ironclownfish @jonyMarino Just asking, would it be possible to have the packaged Blocks binary from the Azure Pipelines available to download? Described here https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/artifacts-overview?view=azure-devops (I haven't myself gone through it completely)
Also mentioned here - #2866 (comment)

Just a follow-up, could an API call like this work - https://docs.microsoft.com/en-us/rest/api/azure/devops/build/artifacts/get?view=azure-devops-rest-4.1?
Need to figure out the variables though, and mostly needs access

@rajat2004
Copy link
Contributor Author

Replaced by #3364

@rajat2004 rajat2004 closed this Feb 2, 2021
@rajat2004 rajat2004 deleted the ap-distance-sensor branch April 16, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant