Update rpclib to new release #3642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the contribution @rajat2004! Tested both windows and ubuntu builds, and ran the hello_drone.py, box.py, and pause_continue_drone.py scripts. Didn't notice any issues so I am moving ahead with merging. |
|
I get a similar error as in issue#631 for ClockSpeed of 50 and above. It's not frequent though. Is this expected for such high ClockSpeeds? Are the testing done only for ClockSpeed=1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
About
This PR changes the rpclib being used from @madratman's fork back to the original rpclib. This was changed in #2340 due to a fix not present at the time in the repository.
The original repo now has a new 2.3.0 release and there's a new maintainer and bug fixes, etc will be applied.
This is a draft PR currently since it still requires testing, which I'll try to do in the next day or 2. Version 2.2.1 was hardcoded in a lot of places, some of which gets reduced as well
How Has This Been Tested?
Tested using
hello_car.py, everything working fine. Intend to do a multi-threaded script test as well, possibly using thesimAddVehicleAPI for which the script needs to be improved as well.Screenshots (if appropriate):