[Main] Add npm-pack and npm-publish tasks #2033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Apr 5, 2023
MSNev
commented
- Fix publishing content of npm packages
- Fix issues related to dependencies for tests
- Update Release Packaging location
- Update NPM publish scripts
MSNev
requested review from
JacksonWeber,
Karlie-777,
hectorhdzg,
ramthi and
siyuniu-ms
MSNev
commented
Apr 5, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MSNev
force-pushed
the
MSNev/ReleaseFixes
branch
from
0ea9802 to
65573f5
Compare
MSNev
commented
Apr 5, 2023
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| import { getGlobal, objAssign, objCreate, objDefineProp, objHasOwnProperty, throwTypeError } from "@nevware21/ts-utils"; |
Collaborator
Author
There was a problem hiding this comment.
Re-Using the ts-utils versions to avoid the repeated code -- provides smaller final code.
MSNev
commented
Apr 5, 2023
| } | ||
| }); | ||
|
|
||
| this.testCase({ |
Collaborator
Author
There was a problem hiding this comment.
Just adding tests so that unexpected changes from ts-utils don't break this functionality
MSNev
commented
Apr 5, 2023
| funcNames: [ /[^\w\"\']Date\.(now)\(/g ], | ||
| errorMsg: "[%funcName%] is not supported Date method in a IE/ES5 environment, use a helper function or add explicit check for existence" | ||
| }, | ||
| { |
Collaborator
Author
There was a problem hiding this comment.
We didn't need most of these previously because TypeScript with ES3 targeting stopped us, now that we are targeting ES5 and we still support IE then we needed to add these new restrictions.
MSNev
force-pushed
the
MSNev/ReleaseFixes
branch
2 times, most recently
from
50aa0af to
a161b44
Compare
Karlie-777
approved these changes
Apr 6, 2023
MSNev
force-pushed
the
MSNev/ReleaseFixes
branch
from
a161b44 to
c340caa
Compare
- Fix publishing content of npm packages - Fix issues related to dependencies for tests - Update Release Packaging location - Update NPM publish scripts
MSNev
force-pushed
the
MSNev/ReleaseFixes
branch
from
c340caa to
9bb0889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.