[BUG] ClickAnalytics throwing errors in console #2075 #2077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
requested review from
JacksonWeber,
Karlie-777,
hectorhdzg,
ramthi and
siyuniu-ms
MSNev
commented
May 16, 2023
| _contentHandler = new DomContentHandler(_config, logger); | ||
| let metaTags = _contentHandler.getMetadata(); | ||
| _pageAction = new PageAction(this, _config, _contentHandler, _config.callback.pageActionPageTags, metaTags, logger); | ||
| _pageAction = new PageAction(_self, _config, _contentHandler, _config.callback.pageActionPageTags, metaTags, logger); |
Collaborator
Author
There was a problem hiding this comment.
This is the source of the issue in that when the onConfigChange is re-called the this is undefined which then causes the creation of a new PageAction with undefined as the ClickAnalytics instance.
I've also looked for a "fixed" other potential issues of the same in the other classes. This doesn't replace "all" of the this usages as there are some where the this does need to represent the current execution context (ie. this)
JacksonWeber
approved these changes
May 16, 2023
Karlie-777
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.