Skip to content

change loader src when detect IE #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siyuniu-ms merged 3 commits into from
Jul 18, 2023
Merged

change loader src when detect IE #2099

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0e6bc0
Update snippet.ts
siyuniu-ms Jul 7, 2023
121c037
Update snippet.ts
siyuniu-ms Jul 15, 2023
28c8daa
Update snippet.ts
siyuniu-ms Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion tools/applicationinsights-web-snippet/src/snippet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,15 @@ import { IConfiguration, Snippet } from "@microsoft/applicationinsights-web";
version: 2.0, // initialization version, if this is not 2.0 the previous scripts fail to initialize
config: aiConfig
};
function isIE() {
let nav = navigator;
if (nav) {
let userAgent = (nav.userAgent || "").toLowerCase();
return (userAgent.indexOf("msie") !== -1 || userAgent.indexOf("trident/") !== -1);
}
return false;
}

function _parseConnectionString() {
let fields:Fields = {};
let connectionString = aiConfig.connectionString;
Expand Down Expand Up @@ -169,8 +178,15 @@ import { IConfiguration, Snippet } from "@microsoft/applicationinsights-web";
}

// Assigning these to local variables allows them to be minified to save space:
let targetSrc = (aiConfig as any)["url"] || snipConfig.src
let targetSrc : string = (aiConfig as any)["url"] || snipConfig.src
if (targetSrc) {
if (isIE() && targetSrc.indexOf("ai.3") !== -1) {
// This regex matches any URL which contains "\ai.3." but not any full versions like "\ai.3.1" etc
targetSrc = targetSrc.replace(/(\/)(ai\.3\.)([^\d]*)$/, function(_all, g1, g2) {
Copy link
Collaborator

@MSNev MSNev Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need to add the TypeScript definition for these, they are all strings so adding : string as the type should be all that is needed here.

return g1 + "ai.2" + g2;
});
// let message = "Load Version 2 SDK instead to support IE"; // where to report this error?
}
const _handleError = (evt?: any) => {
loadFailed = true;
appInsights.queue = []; // Clear the queue
Expand Down