Skip to content

[Main][Task]28846327: Fix Offline Default Max in Storage Time to 7 Days #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karlie-777 merged 2 commits into from
Jul 27, 2024
Merged

[Main][Task]28846327: Fix Offline Default Max in Storage Time to 7 Days #2386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
316b8a0
update offline default max in storage time
Karlie-777 Jul 26, 2024
39dd831
Merge branch 'main' into karlie/fixmstodays
Karlie-777 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion channels/offline-channel-js/Tests/Unit/src/dbprovider.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class OfflineDbProviderTests extends AITestClass {
let expectedStorageKey = "AIOffline_1_dc.services.visualstudio.com";
Assert.equal(ctx[0], expectedStorageKey, "should have expected storage");
Assert.equal(ctx[1], "dc.services.visualstudio.com", "default endpoint is set");
let expectedMaxStorageTime = 10080000;
let expectedMaxStorageTime = 604800000;
Assert.equal(ctx[2], expectedMaxStorageTime, "default Max time is set");
Assert.ok(!provider.supportsSyncRequests(), "support sync should be set to false");
// this test will run database creation/dbupgrade as well
Expand Down
3 changes: 2 additions & 1 deletion channels/offline-channel-js/src/Interfaces/IOfflineProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ export interface IOfflineChannelConfiguration {

/**
* [Optional] Identifies the maximum time in ms that items should be in persistent storage.
* default: 10080000 (around 7days)
* default: 10080000 (around 2.8 hours) for versions <= 3.3.0
* default: 604800000 (around 7days) for versions > 3.3.0
*/
inStorageMaxTime?: number;

Expand Down
2 changes: 1 addition & 1 deletion channels/offline-channel-js/src/Providers/IndexDbProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { IndexedDbHelper } from "./IndexDbHelper";
//TODO: move all const to one file
const EventsToDropAtOneTime = 10; // If we fail to add a new event this is the max number of events we will attempt to remove to make space
const StoreVersion = 1; // The Current version for the stored items, this will be used in the future for versioning
const OrhpanedEventThresholdInMs = 10080000; // 7 days
const OrhpanedEventThresholdInMs = 604800000; // 7 days
const UnknowniKey = "Unknown";
const ErrorMessageUnableToAddEvent = "DBError: Unable to add event";
const MaxCriticalEvtsDropCnt = 2;
Expand Down
2 changes: 1 addition & 1 deletion channels/offline-channel-js/src/Providers/WebStorageProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const Version = "1";
const DefaultStorageKey = "AIOffline";
const DefaultMaxStorageSizeInBytes = 5000000;
const MaxCriticalEvtsDropCnt = 2;
const DefaultMaxInStorageTime = 10080000; //7*24*60*60*1000 7days
const DefaultMaxInStorageTime = 604800000; //7*24*60*60*1000 7days
// [Optional for version 1]: TODO: order event by time

interface IJsonStoreDetails {
Expand Down