[main] enhance exception telemetry with optional script Information #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
reviewed
Aug 2, 2024
| * [Optional] If set to true, when exception is sent out, the SDK will also send out all scripts basic info that are loaded on the page. | ||
| * Notice: This would increase the size of the exception telemetry. | ||
| */ | ||
| getExceptionScriptsInfo?: boolean; |
Collaborator
There was a problem hiding this comment.
Rather than "get" (which to me sounds like a function) we want to call out that this is an option, which is where we have in the past called these "enableXXXX" or "disableXXXX" in this case maybe something like "includeXXX" and as we are also adding the debug logs and maybe some other stuff for the internal project, perhaps we call these out into an exception config (like the Cookie manager config)
So something like
expCfg: {
inclScripts: true/false,
getDbgLogs: () => string[]
}We can call the interface name for this something meaningful like IExceptionConfig as I suspect that we are going to need additional optional "values" that partners will need to include.
MSNev
reviewed
Aug 2, 2024
MSNev
reviewed
Aug 2, 2024
MSNev
reviewed
Aug 2, 2024
MSNev
reviewed
Aug 5, 2024
| export function findAllScripts(doc: any) { | ||
| let scripts = doc.getElementsByTagName("script"); | ||
| let result: scriptsInfo[] = []; | ||
| for (let i = 0; i < scripts.length; i++) { |
Collaborator
There was a problem hiding this comment.
Lets use arrForEach to help with minification
MSNev
reviewed
Aug 5, 2024
| crossOrigin?: string; | ||
| async?: boolean; | ||
| defer?: boolean; | ||
| referrePolicy?: string; |
MSNev
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.