Skip to content

[main] [BUG] [Snippet] Fix Unhandled exceptions are reported twice #2442 #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
siyuniu-ms wants to merge 3 commits into from
Closed

[main] [BUG] [Snippet] Fix Unhandled exceptions are reported twice #2442 #2449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f70c612
add check the fix
siyuniu-ms Nov 25, 2024
74a5eee
Update AnalyticsPlugin.ts
siyuniu-ms Nov 26, 2024
1cdec91
Merge branch 'main' into siyu/snippetFix
siyuniu-ms Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,13 @@ The current version of the snippet is version 8, the version is identified by th
// onInit: null, // Once the application insights instance has loaded and initialized this callback function will be called with 1 argument -- the sdk instance (DO NOT ADD anything to the sdk.queue -- As they won't get called)
// sri: false, // Custom optional value to specify whether fetching the snippet from integrity file and do integrity check
cfg: { // Application Insights Configuration
connectionString: "YOUR_CONNECTION_STRING"
connectionString: "YOUR_CONNECTION_STRING",
extensionConfig: {
ApplicationInsightsAnalytics: {
autoExceptionInstrumented: true // Workaround for older SDK versions to prevent duplicate hooking of window.onerror.
// Fixed in v3.3.5; recommended for versions prior to this.
}
},
}
});
</script>
Expand Down
2 changes: 1 addition & 1 deletion extensions/applicationinsights-analytics-js/src/JavaScriptSDK/AnalyticsPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ export class AnalyticsPlugin extends BaseTelemetryPlugin implements IAppInsights
_self._addHook(onConfigChange(_extConfig, () => {
_disableExceptionTracking = _extConfig.disableExceptionTracking;

if (!_disableExceptionTracking && !_autoExceptionInstrumented && !_extConfig.autoExceptionInstrumented) {
if (!_disableExceptionTracking && !_autoExceptionInstrumented && !_extConfig.autoExceptionInstrumented && !_self.core.config["autoExceptionInstrumented"]) {
Copy link
Contributor

@Karlie-777 Karlie-777 Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking, maybe we can add a test to the change?

// We want to enable exception auto collection and it has not been done so yet
_addHook(InstrumentEvent(_window, "onerror", {
ns: _evtNamespace,
Expand Down
Loading