Skip to content

Conversation

@siyuniu-ms
Copy link
Contributor

No description provided.

@MSNev MSNev requested a review from Copilot January 7, 2025 23:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • tools/chrome-debug-extension/src/components/configurationSelection.tsx: Evaluated as low risk
Comments suppressed due to low confidence (2)

tools/chrome-debug-extension/src/components/telemetryViewer.tsx:114

  • Ensure default settings are applied if chrome.storage.local.get call fails.
doAwait(chrome.storage.local.get([filterSettingsCacheKey]), (json: any) => {

tools/chrome-debug-extension/src/components/telemetryViewer.tsx:42

  • [nitpick] The variable name filterSettingsCacheKey should be more descriptive.
chrome.storage.local.set({ [filterSettingsCacheKey]: JSON.stringify(newFilterSettings) });

@siyuniu-ms siyuniu-ms merged commit 81f068e into main Jan 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants