-
Notifications
You must be signed in to change notification settings - Fork 255
[main][debug tool] enable check compressed data #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6c0ff60
fix
siyuniu-ms 40acc18
Update defaultDataSource.ts
siyuniu-ms c5ed4f5
Revert "Update defaultDataSource.ts"
siyuniu-ms fc3f54f
Merge branch 'main' into siyu/compressCheckTool
siyuniu-ms 70645a9
add compress check
siyuniu-ms 12b58fd
Merge branch 'siyu/compressCheckTool' of https://github.com/microsoft…
siyuniu-ms a920bfa
Merge branch 'main' into siyu/compressCheckTool
siyuniu-ms b771e32
Update defaultDataSource.ts
siyuniu-ms 7ca1b8c
Update defaultDataSource.ts
siyuniu-ms 7828c46
Merge branch 'main' into siyu/compressCheckTool
siyuniu-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| "target": "es2016", | ||
| "lib": [ | ||
| "es2017", | ||
| "ES2018.Promise", | ||
| "dom" | ||
| ], | ||
| "sourceMap": true, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While its good to "validate" that it's really gzipped, we should be checking the Encoding header and only attempt this check if it was reported as encoded as gzipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requestHeaders is only available under onBeforeSendHeaders func