Skip to content

Conversation

@bwcampbell9
Copy link

@bwcampbell9 bwcampbell9 commented Mar 5, 2025

Add a config parameter which allows user to specify which elements are auto captured by click analytics.
Includes documentation for the new config parameter and tests for the default behavior and a custom capture element function.

This is required because many pages use non-standard input elements, and all these clicks are missed by the plugin. This includes clicks on Microsoft UI library components like the Formula UI Tab component which is displayed as a <div> with role="tab"

Solution to: #1706, #2318, and #2136

@bwcampbell9 bwcampbell9 requested a review from a team as a code owner March 5, 2025 00:01
@bwcampbell9
Copy link
Author

@bwcampbell9 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@siyuniu-ms
Copy link
Contributor

Hi, since we have specific configuration criteria and other requirements, we will open a new PR to implement this feature ourselves, likely sometime this week.

@bwcampbell9
Copy link
Author

Hi, since we have specific configuration criteria and other requirements, we will open a new PR to implement this feature ourselves, likely sometime this week.

Great thank you! Let me know if there's anything I can do to help my ms alias is brycampbell

@MSNev
Copy link
Collaborator

MSNev commented Apr 30, 2025

As I believe this is being addressed as part of #2504, I'm going to close this PR.

@bwcampbell9 please feel free to add comments if I'm missing understanding the intent, we are also working to attempt to get the link PR into the next release which will be 3.3.7 -- all going well.

@MSNev MSNev closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants