Skip to content

Click Analytics - Fix capturning of HTML events #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karlie-777 merged 1 commit into from
Jun 23, 2025
Merged

Click Analytics - Fix capturning of HTML events #2587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions extensions/applicationinsights-clickanalytics-js/src/handlers/AutoCaptureHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
IDiagnosticLogger, IProcessTelemetryUnloadContext, ITelemetryUnloadState, IUnloadHook, createUniqueNamespace, eventOff, eventOn,
getDocument, getWindow, isNullOrUndefined, mergeEvtNamespace, onConfigChange
} from "@microsoft/applicationinsights-core-js";
import { arrMap, strTrim } from "@nevware21/ts-utils";
import { arrIncludes, arrMap, strTrim } from "@nevware21/ts-utils";
import { ClickAnalyticsPlugin } from "../ClickAnalyticsPlugin";
import { ActionType } from "../Enums";
import { IAutoCaptureHandler, IClickAnalyticsConfiguration, IPageActionOverrideValues } from "../Interfaces/Datamodel";
Expand Down Expand Up @@ -59,7 +59,7 @@ export class AutoCaptureHandler implements IAutoCaptureHandler {
_self._pageAction.capturePageAction(element, overrideValues, customProperties, isRightClick);
}
}

// Process click event
function _processClick(clickEvent: any) {
let win = getWindow();
Expand All @@ -68,7 +68,7 @@ export class AutoCaptureHandler implements IAutoCaptureHandler {
}
if (clickEvent) {
let element = clickEvent.srcElement || clickEvent.target;

// populate overrideValues
var overrideValues: IPageActionOverrideValues = {
clickCoordinateX: clickEvent.pageX,
Expand All @@ -88,15 +88,15 @@ export class AutoCaptureHandler implements IAutoCaptureHandler {
} else {
return;
}

while (element && element.tagName) {
// control property will be available for <label> elements with 'for' attribute, only use it when is a
// valid JSLL capture element to avoid infinite loops
if (element.control && _clickCaptureElements[element.control.tagName.toUpperCase()]) {
if (element.control && arrIncludes(_clickCaptureElements, element.control.tagName.toUpperCase())) {
element = element.control;
}
const tagNameUpperCased = element.tagName.toUpperCase();
if (!_clickCaptureElements[tagNameUpperCased]) {
if (!arrIncludes(_clickCaptureElements, tagNameUpperCased)) {
element = element.parentElement || element.parentNode;
continue;
} else {
Expand Down