[Beta] Updated and remerge [main] to [beta]

[MSNev]

No description provided.

[Copilot]

Pull Request Overview

This PR merges the latest changes from main into the beta branch and introduces URL field redaction support throughout the SDK.

• Added a new fieldRedaction utility (and associated constants) to sanitize credentials and query parameters in URLs.
• Extended IConfiguration with redactUrls and redactQueryParams options and wired redaction into core, common, and extension modules.
• Added comprehensive unit tests covering many redaction scenarios and bumped size thresholds accordingly.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
shared/AppInsightsCore/src/applicationinsights-core-js.ts	Exported the new fieldRedaction helper from the core module
shared/AppInsightsCore/src/JavaScriptSDK/InternalConstants.ts	Defined STR_REDACTED and DEFAULT_SENSITIVE_PARAMS
shared/AppInsightsCore/src/JavaScriptSDK/EnvUtils.ts	Implemented redactUserInfo, redactQueryParameters, and fieldRedaction functions
shared/AppInsightsCore/src/JavaScriptSDK.Interfaces/IConfiguration.ts	Added redactUrls and redactQueryParams config properties
shared/AppInsightsCore/Tests/Unit/src/ApplicationInsightsCore.Tests.ts	Added numerous tests for the new redaction functionality

Comments suppressed due to low confidence (1)

shared/AppInsightsCore/src/JavaScriptSDK/EnvUtils.ts:9

• The IConfiguration interface isn't exported by applicationinsights-core-js.ts. Import it directly from JavaScriptSDK.Interfaces/IConfiguration.ts to avoid a broken module reference.

import { IConfiguration } from "../applicationinsights-core-js";

[Copilot]

In the AWSAccessKeyId test you set redactUrls: false then only run the redaction assertion inside if (config.redactUrls === true), which never executes. Remove that guard or split into enabled/disabled scenarios so the redaction path is actually tested.

Suggested change

	name: "FieldRedaction: should preserve query parameters while redacting auth - AWSAccessKeyId",
	test: () => {
	let config = {redactUrls: false} as IConfiguration;
	const url = "https://www.example.com/path?color=blue&AWSAccessKeyId=secret";
	if (config.redactUrls === true){
	const redactedLocation = fieldRedaction(url, config);
	Assert.equal(redactedLocation, "https://www.example.com/path?color=blue&AWSAccessKeyId=REDACTED");
	}
	Assert.equal(url, "https://www.example.com/path?color=blue&AWSAccessKeyId=secret");
	name: "FieldRedaction: should redact AWSAccessKeyId when redactUrls is true",
	test: () => {
	let config = {redactUrls: true} as IConfiguration;
	const url = "https://www.example.com/path?color=blue&AWSAccessKeyId=secret";
	const redactedLocation = fieldRedaction(url, config);
	Assert.equal(redactedLocation, "https://www.example.com/path?color=blue&AWSAccessKeyId=REDACTED");
	}
	});
	this.testCase({
	name: "FieldRedaction: should not redact AWSAccessKeyId when redactUrls is false",
	test: () => {
	let config = {redactUrls: false} as IConfiguration;
	const url = "https://www.example.com/path?color=blue&AWSAccessKeyId=secret";
	const redactedLocation = fieldRedaction(url, config);
	Assert.equal(redactedLocation, "https://www.example.com/path?color=blue&AWSAccessKeyId=secret");

[Copilot]

Currently non-string inputs (e.g. numbers) get passed to dataSanitizeInput and converted to strings, which conflicts with the test expecting 123545 to remain a number. Consider early-returning non-string values to preserve their types.

Suggested change

	if (isString(url)) {
	url = fieldRedaction(url, config);
	}
	if (!isString(url)) {
	return url; // Early return for non-string inputs to preserve their type
	}
	url = fieldRedaction(url, config);

[Copilot]

[nitpick] The regex in redactUserInfo embeds the max-credential-length ({1,200}) as a magic number. Extract it to a named constant (e.g. MAX_CREDENTIAL_LEN) so it’s clear and can be tweaked consistently.

Suggested change

	return url.replace(/^([a-zA-Z][a-zA-Z0-9+.-]*:\/\/)([^:@]{1,200}):([^@]{1,200})@(.*)$/, "$1REDACTED:REDACTED@$4"); //(/^([a-zA-Z][a-zA-Z0-9+.-]{0,50}:\/\/)([^:@]{0,200})(?::([^@]{0,200}))?@(.*)$/, "$1REDACTED:REDACTED@$4");
	const credentialRegex = new RegExp(`^([a-zA-Z][a-zA-Z0-9+.-]*:\\/\\/)([^:@]{1,${MAX_CREDENTIAL_LEN}}):([^@]{1,${MAX_CREDENTIAL_LEN}})@(.*)$`);
	return url.replace(credentialRegex, "$1REDACTED:REDACTED@$4"); // Redact user credentials