Skip to content

Suppressed credentials inline to avoid credscan false positive #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rads-1996 merged 2 commits into from
Jul 15, 2025
Merged

Suppressed credentials inline to avoid credscan false positive #2622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc9574e
Suppressed credentials inline to avoid credscan false positive
rads-1996 Jul 15, 2025
ae8239c
Used the next line supression syntax to avoid long length issue
rads-1996 Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shared/AppInsightsCore/Tests/Unit/src/ApplicationInsightsCore.Tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2325,6 +2325,7 @@ export class ApplicationInsightsCoreTests extends AITestClass {
name: "FieldRedaction: should handle non-standard port with encoded credentials",
test: () => {
let config = {} as IConfiguration;
//[SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Test file with mock credentials - not actual secrets")]
const url = "https://admin%21:secret%21@server.com:9443/admin";
const redactedLocation = fieldRedaction(url, config);
Assert.equal(redactedLocation, "https://REDACTED:REDACTED@server.com:9443/admin",
Expand Down
4 changes: 2 additions & 2 deletions shared/AppInsightsCore/src/JavaScriptSDK/EnvUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ export function sendCustomEvent(evtName: string, cfg?: any, customDetails?: any)
* @returns The URL with user information redacted
*/
function redactUserInfo(url: string): string {
return url.replace(/^([a-zA-Z][a-zA-Z0-9+.-]*:\/\/)([^:@]{1,200}):([^@]{1,200})@(.*)$/, "$1REDACTED:REDACTED@$4"); //(/^([a-zA-Z][a-zA-Z0-9+.-]{0,50}:\/\/)([^:@]{0,200})(?::([^@]{0,200}))?@(.*)$/, "$1REDACTED:REDACTED@$4");
return url.replace(/^([a-zA-Z][a-zA-Z0-9+.-]*:\/\/)([^:@]{1,200}):([^@]{1,200})@(.*)$/, "$1REDACTED:REDACTED@$4");
}

/**
Expand Down Expand Up @@ -461,7 +461,7 @@ function redactQueryParameters(url: string, config?: IConfiguration): string {
* @returns The redacted URL string or the original string if no redaction was needed or possible.
*/
export function fieldRedaction(input: string, config: IConfiguration): string {
if (!input ||input.indexOf(" ") !== -1) {
if (!input || input.indexOf(" ") !== -1) {
return input;
}
const isRedactionDisabled = config && config.redactUrls === false;
Expand Down