Skip to content

Conversation

@MSNev
Copy link
Collaborator

@MSNev MSNev commented Jul 24, 2025

No description provided.

MSNev and others added 4 commits July 11, 2025 15:56
* Initial plan

* Changes before error encountered

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix tree-shaking annotation syntax - remove incorrect parentheses

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add parentheses around @__PURE__ comments in IOfflineBatch.ts

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add parentheses around @__PURE__ comments for proper TypeScript handling

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
* Suppressed credentials inline to avoid credscan false positive

* Used the next line supression syntax to avoid long length issue
Copilot AI review requested due to automatic review settings July 24, 2025 21:15
@MSNev MSNev requested a review from a team as a code owner July 24, 2025 21:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a beta merge pull request that brings changes from the main branch into the MSNev/beta branch. The changes include code cleanup and security compliance improvements.

  • Removed commented-out regex pattern from URL redaction function
  • Added security suppression comment for test file containing mock credentials

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
shared/AppInsightsCore/src/JavaScriptSDK/EnvUtils.ts Cleaned up commented code in URL redaction function
shared/AppInsightsCore/Tests/Unit/src/ApplicationInsightsCore.Tests.ts Added security suppression comment for test with mock credentials

@MSNev MSNev enabled auto-merge (rebase) July 24, 2025 21:25
auto-merge was automatically disabled July 24, 2025 21:34

Rebase failed

@MSNev MSNev merged commit d946c98 into beta Jul 24, 2025
9 checks passed
@MSNev MSNev deleted the MSNev/beta branch July 24, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants