-
Notifications
You must be signed in to change notification settings - Fork 144
Fix trackRequest HTTP method extraction and ID preservation #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bfcc939
Initial plan for issue
Copilot 4dfee79
Fix trackRequest HTTP method extraction and ID preservation
Copilot 0113533
Apply linter fixes to telemetryClient.ts
Copilot ae6dbb5
Address feedback: focus on HTTP method extraction, remove problematic…
Copilot 5d62911
Merge branch 'main' into copilot/fix-1432
JacksonWeber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
telemetry name could be anything that customer provide, not necessary an HTTP method, issue associated is complaining about the code changing the value they provided, where is the actual name being overridden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The telemetry name is not being overridden - it's preserved as-is on line 193 where
telemetry.nameis passed tostartSpan(). We only extract the HTTP method from the name to correctly set thehttp.methodattribute (previously hardcoded as "HTTP"). The span name stays exactly as the user provided it. The original issue was that the HTTP method attribute was always "HTTP" instead of the actual method like "GET", "POST", etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is name passed in startSpan method changed at some point in OpenTelemetry code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot answer the question above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the name passed to
startSpan()is not changed by OpenTelemetry. The user-providedtelemetry.namebecomes the span name and remains unchanged throughout the OpenTelemetry processing pipeline. The Azure Monitor exporter readsspan.namedirectly and uses it for telemetry without modification. Our implementation correctly preserves the original request name while only extracting the HTTP method from it to set thehttp.methodattribute.