Skip to content

Adds TPM Collector Features using TSS.NET #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gfs wants to merge 90 commits into from
Closed

Adds TPM Collector Features using TSS.NET #398

gfs wants to merge 90 commits into from

Conversation

@gfs
Copy link
Contributor

@gfs gfs commented Apr 22, 2020 •
edited
Loading

Fix #391
Fix #400

@gfs gfs mentioned this pull request Apr 22, 2020
Closed
@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2020

This pull request fixes 1 alert when merging db1cb76 into 3ad3841 - view on LGTM.com

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2020

This pull request fixes 1 alert when merging e599f10 into 3ad3841 - view on LGTM.com

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2020

This pull request introduces 1 alert and fixes 1 when merging dbd5996 into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2020

This pull request introduces 1 alert and fixes 1 when merging 15488fe into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging 0f210d3 into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging ffa83d5 into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging 2fdf429 into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging 00968e7 into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging 0950642 into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging cbba13c into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging efc390f into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging 9ec8a1a into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 2 alerts and fixes 1 when merging eb85b86 into 3ad3841 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging 2da43bd into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging 692d7d3 into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert and fixes 1 when merging 1a79476 into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging fe11baf into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging b9b6de5 into 3ad3841 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 2fa6148 into 9b04c37 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 217e1a2 into 9b04c37 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 6b2b8bd into 9b04c37 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 7f4d77b into 82dd3cb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 708cf84 into 82dd3cb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 09cd84e into 82dd3cb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging b732a56 into 82dd3cb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging d7c8dcf into 82dd3cb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 79280c8 into 82dd3cb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 87e1209 into 82dd3cb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Futile conditional

gfs and others added 20 commits May 6, 2020 21:44
@gfs
Add catch for reading NV
66b73a9
@gfs
Add Deserialization of TPM and KEY objects.
1438100
@gfs
Clean up.
a57b62c
@gfs
New Comparator Tests
4a47f6a 
Directly test comparator and don't rely on collectors.
@gfs
Clean up.
2fa1a85
@gfs
Add Tpm2Tester for utility functions.
90e778e
@gfs
Collect private key portion.
134f823
@gfs
Update Objects
3dbf116
@gfs
Add NvIndex object
468d257
@gfs
Create proper RSA Key class with appropriate serializer,deserializers
5ec44f3
@gfs
Don't read NV unless we are allowed to
a772d7f 
TODO: check if we are allowed to read
@gfs
Don't print out the pcrs.
3c53824
@gfs
Update TpmCollector.cs
0c102eb
@gfs
Update Cli.csproj
013050a
@gfs
Only attempt to read NV When we think its allowed
167d817
@gfs
Fix Tests dependency.
8091544
@gfs
Use blank auth value so that tpmcollector can grab it.
3180cd5
@gfs
Update .gitignore
29912f7
@gfs
Fix #413 (#414)
6f7e3bd 
* Fix #413.

Collection was being slowed down by the ConcurrentQueue which according to https://stackoverflow.com/questions/19326197/net-4-0-concurrent-collection-performance is actually slower than a standard list.  Tested here and the list was significantly faster (20% cpu usage to 900-1000% on my macbook pro)

* AsParallel.ForAll is faster than Parallel.ForEach

* Add unique constrint on runid and identity.
@gfs
Update CollectorTests.cs
e44a5ba
@gfs gfs force-pushed the gfs/TpmCollector branch from cd7449a to e44a5ba Compare May 7, 2020 04:55
@lgtm-com
Copy link

lgtm-com bot commented May 7, 2020

This pull request introduces 1 alert and fixes 2 when merging b0ec2aa into 27980e5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Futile conditional

@lgtm-com
Copy link

lgtm-com bot commented May 7, 2020

This pull request introduces 1 alert and fixes 2 when merging 1242395 into 27980e5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Futile conditional

@gfs gfs mentioned this pull request May 17, 2020
Closed
@gfs
Copy link
Contributor Author

gfs commented Jun 9, 2020

Superceded by #489

@gfs gfs closed this Jun 9, 2020
@gfs gfs deleted the gfs/TpmCollector branch September 15, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Database/Object Serialization Tests Gather TPM Information

2 participants

@gfs