This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Merged
Conversation
…ctionsSample to experimental
…required Runtime settings.
…/Runtime settings and csproj
clearab
approved these changes
May 20, 2021
Contributor
clearab
left a comment
clearab
left a comment
There was a problem hiding this comment.
Great baseline - individual samples and readme's will be reviewed in more detail over the coming weeks.
🔥
Contributor
|
Is the idea to have a set of samples that can be opened directly inside Composer then? Pretty hard to review a 1,500 file, ~500k line diff! |
Contributor
|
@joshgummersall yes - we can iterate on the samples after, this is just setting the baseline. |
joshgummersall
approved these changes
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3284