Avoid posting an error on intentional end #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 544e7e3 suppressed the exception, but it is still reported as an error. directLine.activity$ .filter(activity => activity.type === 'message') .subscribe( message => { console.log("received message ", message) directLine.end(); }, err => console.error // error is logged here );
|
|
Contributor
Author
|
Gentle ping |
Contributor
Author
|
ping? |
Contributor
Author
|
Hello? |
Member
|
hi @orgads. thank you for your patience. we'll look to include this change with our next release. someone will review along with a currently active work-stream. cc @compulim @ckkashyap |
compulim
approved these changes
Sep 27, 2019
Collaborator
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
Looks good to me.
I will add changelog in another PR.
Collaborator
|
It's now released at 0.11.5. https://github.com/microsoft/BotFramework-DirectLineJS/releases/tag/v0.11.5 |
compulim
added a commit
to compulim/BotFramework-DirectLineJS
that referenced
this pull request
Oct 18, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 544e7e3 suppressed the exception,
but it is still reported as an error.