Add streaming protocol support #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckkashyap
force-pushed
the
ckk/protocoljs
branch
from
e636ada to
cbc1842
Compare
…ues, add excludes to webpack config (#190)
Ths test is still commented out because there is an issue in ASE that prevents the test from passing. The fix was validated by running it against DirectLineFlex 2884ae1c356971545b0580297619edb4d610b6cb
compulim
reviewed
Jan 29, 2020
compulim
reviewed
Jan 29, 2020
compulim
reviewed
Jan 31, 2020
compulim
reviewed
Jan 31, 2020
compulim
reviewed
Jan 31, 2020
cwhitten
requested changes
Feb 2, 2020
compulim
reviewed
Feb 5, 2020
Collaborator
|
Please do some testing in IE11. There is a blocking bug on |
cwhitten
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectLine constructor
streamingWebSocket is introduced. This parameter can be used to tell DirectLine to use the streaming protocol.
postActivity and postMessageWithAttachments
Both methods now use the streaming protocol to send messages if there is a streaming connection.
**Tests
Happy paths for posting activities, activities with attachments and receiving welcome messages have automated tests
Unhappy paths of unable to reconnect/connection break were manually tested. The reconnect function has not been tested. I will update its implementation during the review.