Debugging and throttling enhancements for directline-js #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
swagatmishra2007
commented
Nov 21, 2019
swagatmishra2007
commented
- Added support for retry-after header and version information for directline-js to the useragent.
- Interfaced out dependencies with side effects (like Ajax) to make the main code more unit testable and also to be able to inject global functionality
- Added some unit testing infrastructure using the rxjs test scheduler
- Added tests for the new functionality added
npm run watch node --inspect .\node_modules\jest\bin\jest.js directLine.test.ts -t TestWithMocks
compulim
approved these changes
Dec 5, 2019
src/directLine.ts
Outdated
| random: () => number; | ||
| } | ||
|
|
||
| const wrapWithRetry = (source: AjaxCreationMethod, scheduler: IScheduler): AjaxCreationMethod =>{ |
Collaborator
There was a problem hiding this comment.
Suggested change
| const wrapWithRetry = (source: AjaxCreationMethod, scheduler: IScheduler): AjaxCreationMethod =>{ | |
| const wrapAjaxWithRetry = (source: AjaxCreationMethod, scheduler: IScheduler): AjaxCreationMethod =>{ |
simpler changes from PR feedback Co-Authored-By: William Wong <compulim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.