Skip to content

Add locale support to WebChat#3306

Merged
compulim merged 16 commits intomasterfrom
zhiwang/Add-locale-support
Aug 7, 2020
Merged

Add locale support to WebChat#3306
compulim merged 16 commits intomasterfrom
zhiwang/Add-locale-support

Conversation

@timenick
Copy link
Contributor

@timenick timenick commented Jul 14, 2020

Fixes #3296

Description

Update createDirectLine to accept and pass locale option.

compulim
compulim reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is in draft mode, I am just scanning for obvious problems.

@timenick timenick marked this pull request as ready for review July 31, 2020 06:10
@timenick timenick requested a review from compulim July 31, 2020 06:11
@timenick timenick changed the title [Draft] Add locale support Add locale support in WebChat Jul 31, 2020
@timenick timenick changed the title Add locale support in WebChat Add locale support to WebChat Jul 31, 2020
@timenick
Copy link
Contributor Author

timenick commented Jul 31, 2020 •
edited
Loading

The zh-CN test case failed due to the locale feature is not enabled in DLJS.

compulim
compulim reviewed Aug 6, 2020
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for { conversationStartProperties: { locale: { invalid: true } } }. We are expecting the end-to-end will continue to work as if it does not have locale defined.

After this test is added, I will approve and merge it.

compulim
compulim reviewed Aug 6, 2020
View reviewed changes
compulim
compulim reviewed Aug 6, 2020
View reviewed changes
@timenick timenick requested a review from compulim August 6, 2020 09:35
compulim
compulim reviewed Aug 6, 2020
View reviewed changes
compulim
compulim reviewed Aug 6, 2020
View reviewed changes
compulim
compulim reviewed Aug 6, 2020
View reviewed changes
compulim
compulim reviewed Aug 6, 2020
View reviewed changes
compulim
compulim reviewed Aug 6, 2020
View reviewed changes
compulim
compulim reviewed Aug 6, 2020
View reviewed changes
compulim
compulim reviewed Aug 6, 2020
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename test cases.

@compulim
Copy link
Contributor

compulim commented Aug 7, 2020

LGTM!

@compulim compulim merged commit f42ead8 into master Aug 7, 2020
@compulim compulim deleted the zhiwang/Add-locale-support branch August 7, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

@p-nagpal p-nagpal Awaiting requested review from p-nagpal

@youyu16 youyu16 Awaiting requested review from youyu16

@swagatmishra2007 swagatmishra2007 Awaiting requested review from swagatmishra2007

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support locale at StartConversation

2 participants

@timenick @compulim