Skip to content

Mark multi-threaded indexing tests as may_fail #4099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddyashton merged 1 commit into from
Aug 4, 2022
Merged

Mark multi-threaded indexing tests as may_fail #4099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/indexing/test/indexing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,8 @@ const auto max_multithread_run_time = 10s;

// Uses the real classes, and access + update them concurrently
TEST_CASE(
"multi-threaded indexing - in memory" * doctest::test_suite("indexing"))
"multi-threaded indexing - in memory" * doctest::test_suite("indexing") *
doctest::may_fail(true))
{
auto kv_store_p = std::make_shared<kv::Store>();
auto& kv_store = *kv_store_p;
Expand Down Expand Up @@ -707,7 +708,8 @@ class MockTransactionFetcher : public ccf::indexing::TransactionFetcher
};

TEST_CASE(
"multi-threaded indexing - bucketed" * doctest::test_suite("indexing"))
"multi-threaded indexing - bucketed" * doctest::test_suite("indexing") *
doctest::may_fail(true))
{
auto kv_store_p = std::make_shared<kv::Store>();
auto& kv_store = *kv_store_p;
Expand Down