ccrefgen uses PdbFunction.ReadCustomMetadata_OLD instead of ReadCustomMetadata

[krk]

PdbFunction.ReadCustomMetadata_OLD throws when there is an unknown custom metadata.
Roslyn and dynamic local variables introduce metadata types greater than 4 which causes ReadCustomMetadata to throw a PdbDebugException with the message "Unknown custom metadata item kind: {0}"

Repro at https://github.com/krk/CodeContractsRosyln

Note: ccrewrite uses the new ReadCustomMetadata, ccrefgen does not.

[roji]

It seems like I'm getting this error while trying to compile Npgsql. The build output with a stack trace is below, please let me know if I can provide any more info.

(thanks for all the effort making CC work on VS2015!)

1>------ Rebuild All started: Project: Npgsql, Configuration: Debug Any CPU ------
1>  AsmMeta failed with uncaught exception: Unknown custom metadata item kind: 7
1>  Stack trace:    at Microsoft.Cci.Pdb.PdbFunction.ReadCustomMetadata(BitAccess bits)
1>     at Microsoft.Cci.Pdb.PdbFunction..ctor(ManProcSym proc, BitAccess bits)
1>     at Microsoft.Cci.Pdb.PdbFunction.LoadManagedFunctions(BitAccess bits, UInt32 limit, Boolean readStrings)
1>     at Microsoft.Cci.Pdb.PdbFile.LoadFuncsFromDbiModule(BitAccess bits, DbiModuleInfo info, IntHashTable names, ArrayList funcList, Boolean readStrings, MsfDirectory dir, Dictionary`2 nameIndex, PdbReader reader, Dictionary`2 sourceCache)
1>     at Microsoft.Cci.Pdb.PdbFile.LoadFunctions(Stream read, Dictionary`2& tokenToSourceMapping, String& sourceServerData)
1>     at Microsoft.Cci.PdbReader..ctor(Stream pdbStream, IMetadataHost host)
1>     at AsmMeta.AsmMeta.Run()
1>     at AsmMeta.AsmMeta.RealMain(String[] args)
1>     at AsmMeta.AsmMeta.Main(String[] args)
1>  elapsed time: 226.1501ms
1>C:\Program Files (x86)\Microsoft\Contracts\MsBuild\v14.0\Microsoft.CodeContracts.targets(356,5): error MSB3073: The command ""C:\Program Files (x86)\Microsoft\Contracts\Bin\ccrefgen.exe" "@obj\Debug\Npgsqlccrefgen.rsp"" exited with code 1.
========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========

[SergeyTeplyakov]

Small repo project would be helpful!

[roji]

I'd love to help, but the stack trace gives no indication at all of where the error is coming from... Do you have some method/pattern of isolation in this case? Or should I simply attempt to cut out code until I manage to isolate?

[SergeyTeplyakov]

What version are you using? Can you try new release? This one: https://github.com/Microsoft/CodeContracts/releases/tag/v.1.9.10709.0

[SergeyTeplyakov]

Trying to reproduce and test the fix.

[SergeyTeplyakov]

I tried to create simple console application and added a dependency to Npgsql. Added new Npgsql.NpgsqlConnection() but was able to compile this using latest version...

Should I do something else?

[roji]

@SergeyTeplyakov, am using the new version just published (v.1.9.10709.0). Sorry for not being clearer, but the error happens when compiling the project, not when running anything. So just clone the develop branch of Npgsql and try to compile it in VS2015 and you should get the error.

I could go eliminating Contract.Requires/Contract.Ensures until the error is gone, this way we isolate the issue - do you have a better idea?

[SergeyTeplyakov]

No need to remove anything. There is a fix that I didn't apply - #33. So I'll try to apply it locally and then will check is it fixed or not.

[roji]

OK great @SergeyTeplyakov, I'll look out for a new version. Let me know if there's anything else I can help with on this.

[SergeyTeplyakov]

Thanks, @roji! I'll push an update soon if the fix will solve the issue.

[SergeyTeplyakov]

Could you please backup your old Contract folder (Program Files x86\Microsoft\Contracts\bin) and unzip this (http://files.rsdn.ru/34036/ccrefgen.zip) new ccrefgen version there. Could you please check it?