Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Conversation

@fedotovalex
Copy link
Contributor

This fixes #186.

@SergeyTeplyakov, will you be adding a unit test for this or do you want me to look into this?

@SergeyTeplyakov
Copy link
Contributor

Maybe I missed something, but it seems that current testing infrastructure is not suited for this test scenario. UnitTests project (Regressions/Foxtrot/UnitTests) is not suited because it rewrites assemblies manually but there is no simple way to rewrite chains of assemblies.

So I'm not sure how to automate this process for this fix. It is possible to add two projects and just emulate this specific case, but I don't think this is a good solution.

Any ideas how to automate such kind of stuff?

@fedotovalex
Copy link
Contributor Author

My idea was to let the test run as usual and then try reading the rewritten assembly back the same way ccrewrite does it.

I just committed a proof of concept on this branch, take a look. It's not a 100% reproduction of the original issue, but it is good enough to catch the problem and to confirm it was indeed fixed.

@SergeyTeplyakov
Copy link
Contributor

Solution looks good for me!

SergeyTeplyakov added a commit that referenced this pull request Aug 12, 2015
ccrewrite: properly escaping type names when serializing metadata
@SergeyTeplyakov SergeyTeplyakov merged commit 8948852 into microsoft:master Aug 12, 2015
@fedotovalex fedotovalex deleted the fix-186 branch August 21, 2015 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ccrewrite produces an incorrect type name in IteratorStateMachineAttribute with some generic types

2 participants