Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Conversation

@yaakov-h
Copy link
Contributor

Fixes for:

@SergeyTeplyakov
Copy link
Contributor

It seems that there is a bunch of commits for this fix:), but everything looks good to me.

If all the tests will pass, I'll merge it.

@yaakov-h
Copy link
Contributor Author

Tests.RewriterTest.BuildRewriteRunFromSourcesRoslynV45 [SKIP]
Old Roslyn bits are not compatible with CCRewrite. Test (and old binaries) should be removed in the next iteration."

Heh.

@SergeyTeplyakov
Copy link
Contributor

@yaakov-h Yeah... I don't event sure what exactly this options.IsLegacyRoslyn = true; means. Because another test (next to skipped one) is still enabled. So this comment doesn't means that roslyn compiler ignored.

@SergeyTeplyakov SergeyTeplyakov merged commit bf32538 into microsoft:master May 24, 2016
@yaakov-h yaakov-h deleted the wtg/wip/WI00119105 branch May 25, 2016 03:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

2 participants