Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

cleanup: Remove IfThenElse StringBuilder extension #397

Merged
tonybendis merged 1 commit into from
Jun 10, 2022
Merged

cleanup: Remove IfThenElse StringBuilder extension #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions src/Tes/Models/TesResources.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,26 +89,14 @@ public override string ToString()
.Append(" RamGb: ").Append(RamGb).Append('\n')
.Append(" DiskGb: ").Append(DiskGb).Append('\n')
.Append(" Zones: ")
.IfThenElse(
Zones?.Count > 0,
s => s.Append(string.Join(",", Zones)),
s => s)
.Append(
Zones?.Count > 0 ?
string.Join(",", Zones) : null)
.Append('\n')
.Append(" BackendParameters: ")
.IfThenElse(
BackendParameters?.Keys.Count > 0,
s =>
{
var keyValues = new List<string>();

foreach (var key in BackendParameters.Keys)
{
keyValues.Add($"({key},{BackendParameters[key]})");
}

return s.Append(string.Join(",", keyValues));
},
s => s)
.Append(
BackendParameters?.Keys.Count > 0 ?
string.Join(",", BackendParameters.Select(kv => $"({kv.Key},{kv.Value})")) : null)
.Append('\n')
.Append(" BackendParametersStrict: ").Append(BackendParametersStrict).Append('\n')
.Append("}\n")
Expand Down Expand Up @@ -241,10 +229,4 @@ public override int GetHashCode()
#pragma warning restore 1591
#endregion Operators
}

internal static class StringBuilderSelectorExtensions
{
public static StringBuilder IfThenElse(this StringBuilder builder, bool @if, Func<StringBuilder, StringBuilder> then, Func<StringBuilder, StringBuilder> @else)
=> @if ? then(builder) : @else(builder);
}
}
14 changes: 6 additions & 8 deletions src/Tes/Models/TesServiceInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,14 @@ public override string ToString()
.Append(" Name: ").Append(Name).Append('\n')
.Append(" Doc: ").Append(Doc).Append('\n')
.Append(" Storage: ")
.IfThenElse(
Storage?.Count > 0,
s => s.Append(string.Join(",", Storage)),
s => s)
.Append(
Storage?.Count > 0 ?
string.Join(",", Storage) : null)
.Append('\n')
.Append(" TesResourcesSupportedBackendParameters: ")
.IfThenElse(
TesResourcesSupportedBackendParameters?.Count > 0,
s => s.Append(string.Join(",", Enum.GetNames(typeof(TesResources.SupportedBackendParameters)))),
s => s)
.Append(
TesResourcesSupportedBackendParameters?.Count > 0 ?
string.Join(",", Enum.GetNames(typeof(TesResources.SupportedBackendParameters))) : null)
.Append('\n')
.Append("}\n")
.ToString();
Expand Down