Don't make void* params Span<byte> in friendly methods #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous change to improve pointer signatures went a little further than intended. There were cases where un-annotated
void*parameters were getting turned intoSpan<byte>which made these methods harder to work with. This restores the behavior of those parameters back to the way they were. You can see some of the deltas in the VerifySignature test cases that I changed back.I also added a test case to call some of the functions like VerQueryValue which were problematic with the previous change.
I also noticed that the build task mode wasn't giving line numbers in NativeMethods.txt when an API failed to generate so I fixed that.