Preserve pointer return types #1534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevansaks
force-pushed
the
user/jevansaks/preservepointerreturn
branch
from
9fe8111 to
92d1c4a
Compare
manodasanW
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function returns a pointer, like WTHelperProvDataFromStateData, we need to make sure that type is preserved in the cswin32 signature. We were losing the pointer indirection when PointerTypeHandleInfo was thinking it could use
out. We can't do anything fancy to marshal pointer returns so we'll just pass along another bit in the TypeSyntaxSettings to let callees know it's a return value and force it to stay as pointer type.I've also been diffing the outputs of the "FullGeneration" before/after changes like this but I kept getting stymied because the list of types and methods was not always in the same order. I added a step to sort those lists in the "GenerateAll" step. These methods are only called during testing so adding a sort doesn't seem too bad.
Fixes #992