feat: Remove use-sync-external-store from expectedNpmVersionFailures.txt #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
requested review from
andrewbranch,
jakebailey and
sandersn
as code owners
sandersn
approved these changes
Apr 2, 2025
Member
|
How does removing from this list work when the linked PR adds to the attw erroring list? |
Member
|
This list means that DefinitelyTyped declares a major version of a types package that doesn’t have a matching implementation on npm. attw can’t possibly run in that scenario since there’s no implementation package version it can use as a source of truth. The DT PR bumps use-sync-external-store to a version that actually exists, so attw can start running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For once DefinitelyTyped/DefinitelyTyped#72360 landed