Fix C_ASSERT linkage conflicts when building with MinGW-w64#332
Open
conorKotwasinski wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix C_ASSERT linkage conflicts when building with MinGW-w64#332conorKotwasinski wants to merge 1 commit intomicrosoft:mainfrom
conorKotwasinski wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
|
@conorKotwasinski please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a compilation error that occurs when building Detours with MinGW-w64 toolchain. The issue arises from conflicting C_ASSERT declarations between ws2tcpip.h (C++ linkage) and detours.h (C linkage).
The fix moves C_ASSERT declarations out of the extern "C" block to preserve C++ linkage consistently. This allows Detours to compile successfully with MinGW-w64 while maintaining the same behavior.
Specifically:
This is important for projects using MinGW-w64 to build applications that depend on Detours, particularly when working with network-related functionality that requires ws2tcpip.h.
Before this change, attempting to build with MinGW-w64 would fail with:
conflicting declaration of 'void __C_ASSERT__(int*)' with 'C' linkageThe fix allows seamless integration while keeping the original verification logic intact.