DevSkim CLI not suppressing ignored finding

[coderpatros]

The DevSkim extension for VS Code behaves as expected. But the DevSkim CLI still reports the finding.

To reproduce create a js file with these two lines in it...

var s = "http://www.example.com/";
var s = "http://www.example.com/"; //Devskim: ignore DS137138 

You can see the VS Code extension has identified the http in the first line but not the second...

Then running the DevSkim CLI gives this result...

[coderpatros]

I've gone digging and can see the issue.

Should I add it in as default behaviour, opt in via command line option, or default with an option to disable the suppression?

Personally I think this should be the default behaviour, and think most people would expect the same. And I can see a use case for optionally disabling the suppression.

[coderpatros]

I've made changes for my own use here https://github.com/patros/DevSkim/commits/cli-suppression

Once I get an idea of what the default behaviour should be I can create a pull request.

[coderpatros]

Resolved by #77 which is now merged