Conversation
|
|
||
| <match oms.api.ContainerNodeInventory**> | ||
| type out_oms_api | ||
| <match oms.containerinsights.ContainerNodeInventory**> |
There was a problem hiding this comment.
I still need to merge ci_feature into feature/customMetrics. That is why this change is seen. I merged from ci_feature into my topic branch
| @log.debug "After check_custom_metrics_availability process_incoming_stream #{@process_incoming_stream}" | ||
| end | ||
|
|
||
| def check_custom_metrics_availability |
There was a problem hiding this comment.
This function is in multiple places now. Good reason to put it as a library & ref it..
| "data": { | ||
| "baseData": { | ||
| "metric": "%{metricName}", | ||
| "namespace": "insights.container/nodes", |
There was a problem hiding this comment.
can this go to 'pods' namespace instead of 'nodes' ?
There was a problem hiding this comment.
that will create too many namespaces. I think it makes sense to have one single namespace for container insights. This will also cause discoverability issues. We can't expect customers to go check every namespace to see what metrics each one has. Just my thoughts
There was a problem hiding this comment.
#1 ) There are not much restrictions on the num namespaces
#2) So you expect customers to look for podcount under /nodes (and will make it easier to discover than putting them under 'pods' ? In the futuire when we add pod cpu, we will add it under nodes? then how about node cpu ? If i am looking for charting anything podlevel its easy to understand to go to pods namespace.
3) either flatten everything and put under default namespace or catagorize it properly.
| containerNodeInventoryRecord['DockerVersion'] = dockerVersion | ||
| # ContainerNodeInventory data for docker version and operating system. | ||
| containerNodeInventoryEventStream.add(emitTime, containerNodeInventoryRecord) if containerNodeInventoryRecord | ||
| containerNodeInventoryWrapper = { |
There was a problem hiding this comment.
Ignore this change. Since the PR was created before the target branch was updated, this shows up.
…/Docker-Provider into dilipr/nodePodMetrics2
2 participants
No description provided.