Skip to content

Collect container last state #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishiy merged 4 commits into from
Jul 15, 2019
Merged

Collect container last state #235

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0885962
updating the OMS agent to also collect container last state
Jul 2, 2019
fb88e51
changed a comment
Jul 8, 2019
3015f9f
git surrounded ContainerLastStatus code in a begin/rescue block
Jul 8, 2019
c401e9c
added a lot of error checking and logging
Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions source/code/plugin/in_kube_podinventory.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,38 @@ def parse_and_emit_records(podInventory, serviceList)
record["ContainerStatusReason"] = containerStatus[containerStatus.keys[0]]["reason"]
end
end

# Record the last state of the container. This may have information on why a container was killed.
begin
if !container["lastState"].nil? && container["lastState"].keys.length == 1
lastStateName = container["lastState"].keys[0]
lastStateObject = container["lastState"][lastStateName]
if !lastStateObject.is_a?(Hash)
raise "expected a hash object. This could signify a bug or a kubernetes API change"
end

if lastStateObject.key?("reason") && lastStateObject.key?("startedAt") && lastStateObject.key?("finishedAt")
newRecord = Hash.new
newRecord["lastState"] = lastStateName # get the name of the last state (ex: terminated)
newRecord["reason"] = lastStateObject["reason"] # (ex: OOMKilled)
newRecord["startedAt"] = lastStateObject["startedAt"] # (ex: 2019-07-02T14:58:51Z)
newRecord["finishedAt"] = lastStateObject["finishedAt"] # (ex: 2019-07-02T14:58:52Z)

# only write to the output field if everything previously ran without error
record["ContainerLastStatus"] = newRecord
else
record["ContainerLastStatus"] = Hash.new
end
else
record["ContainerLastStatus"] = Hash.new
end
rescue => errorStr
$log.warn "Failed in parse_and_emit_record pod inventory while processing ContainerLastStatus: #{errorStr}"
$log.debug_backtrace(errorStr.backtrace)
ApplicationInsightsUtility.sendExceptionTelemetry(errorStr)
record["ContainerLastStatus"] = Hash.new
Copy link
Member

@vishiy vishiy Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, you are assuming all these properties exist all the time. Is that true ? Can you please add check for existence ?

end

podRestartCount += containerRestartCount
records.push(record.dup)

Expand Down