Skip to content

Fix Casing Bug #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r-dilip merged 1 commit into from
Feb 4, 2020
Merged

Fix Casing Bug #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/code/plugin/KubernetesApiClient.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def isNodeMaster
def getNodesResourceUri(nodesResourceUri)
begin
# For ARO v3 cluster, filter out all other node roles other than compute
if IsAROV3Cluster
if isAROV3Cluster()
if !nodesResourceUri.nil? && !nodesResourceUri.index("?").nil?
nodesResourceUri = nodesResourceUri + "&labelSelector=node-role.kubernetes.io%2Fcompute%3Dtrue"
else
Expand Down Expand Up @@ -390,7 +390,7 @@ def getContainerResourceRequestsAndLimits(metricJSON, metricCategory, metricName
end

# For ARO, skip the pods scheduled on to master or infra nodes to ingest
if IsAROV3Cluster && !pod["spec"].nil? && !pod["spec"]["nodeName"].nil? &&
if isAROV3Cluster() && !pod["spec"].nil? && !pod["spec"]["nodeName"].nil? &&
( pod["spec"]["nodeName"].downcase.start_with?("infra-") ||
pod["spec"]["nodeName"].downcase.start_with?("master-") )
next
Expand Down