Skip to content

[Not for ci_dev] Moving out KubePodInventory to a separate process#501

Closed
gracewehner wants to merge 62 commits intoci_dev_oneagentfrom
grwehner/oneagent
Closed

[Not for ci_dev] Moving out KubePodInventory to a separate process#501
gracewehner wants to merge 62 commits intoci_dev_oneagentfrom
grwehner/oneagent

Conversation

@gracewehner
Copy link
Contributor

Team, please take a look at the code changes that David and I have been working on. This is only for the replicaset, the daemonset will still use the prod image. The in_kube_podinventory plugin is separated out from omsagent into a fluentd process that's running the latest version of fluentd. KubePodinventory data is sent through oneagent whereas the other data types collected in in_kube_podinventory plugin are still sent through the out_mdm and out_oms plugins. Everything else is still using omsagent. Telemetry is collected for the cpu usage of fluentd, omsagent, and oneagent.

@daweim0
Copy link
Contributor

daweim0 commented Feb 11, 2021

I have a basic question. Why do we need to duplicate all the files for the new fluent? what is the fundamental difference?

There are some slight differences (mostly adding Fluent:: to the beginning of names). Coppying all the files seemed cleanest, but I'm open to merging the two plugin folders.

Copy link
Contributor

@ganga1980 ganga1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @daweim0 , @gracewehner, there are few bug fixes missing in this agent, are you planning to take those fixes? For example cadvisor bug fix #504
#505

@daweim0
Copy link
Contributor

daweim0 commented Feb 23, 2021

Thanks, I'll pull those fixes in.

Please note there are other fixes missing as well, for example security vulnerability in apt #492. I think, it will be good to take latest bits and do quick validation, and share the final bits to cortana team.

@daweim0 daweim0 marked this pull request as draft May 28, 2021 03:29
@daweim0
Copy link
Contributor

daweim0 commented May 28, 2021

(converting to a draft since this is not meant to be merged)

@github-actions
Copy link

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This PR was closed because it has been stalled for 12 days with no activity.

@github-actions github-actions bot closed this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants