Skip to content

Added support for passwords starting with dash (-) to monitoring scripts #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ganga1980 merged 2 commits into from
Aug 14, 2021
Merged

Added support for passwords starting with dash (-) to monitoring scripts #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c6f2ff
Support az login for passwords starting with dash ('-')
Aug 12, 2021
217812c
Merge branch 'microsoft:ci_dev' into ci_dev
vladimir-babichev Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/onboarding/managed/disable-monitoring.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ remove_monitoring_tags()

if [ "$isUsingServicePrincipal" = true ] ; then
echo "login to the azure using provided service principal creds"
az login --service-principal --username $servicePrincipalClientId --password $servicePrincipalClientSecret --tenant $servicePrincipalTenantId
az login --service-principal --username="$servicePrincipalClientId" --password="$servicePrincipalClientSecret" --tenant="$servicePrincipalTenantId"
else
echo "login to the azure interactively"
az login --use-device-code
Expand Down
2 changes: 1 addition & 1 deletion scripts/onboarding/managed/enable-monitoring.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ install_helm_chart() {
login_to_azure() {
if [ "$isUsingServicePrincipal" = true ]; then
echo "login to the azure using provided service principal creds"
az login --service-principal --username $servicePrincipalClientId --password $servicePrincipalClientSecret --tenant $servicePrincipalTenantId
az login --service-principal --username="$servicePrincipalClientId" --password="$servicePrincipalClientSecret" --tenant="$servicePrincipalTenantId"
else
echo "login to the azure interactively"
az login --use-device-code
Expand Down
2 changes: 1 addition & 1 deletion scripts/onboarding/managed/upgrade-monitoring.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ upgrade_helm_chart_release() {
login_to_azure() {
if [ "$isUsingServicePrincipal" = true ]; then
echo "login to the azure using provided service principal creds"
az login --service-principal --username $servicePrincipalClientId --password $servicePrincipalClientSecret --tenant $servicePrincipalTenantId
az login --service-principal --username="$servicePrincipalClientId" --password="$servicePrincipalClientSecret" --tenant="$servicePrincipalTenantId"
else
echo "login to the azure interactively"
az login --use-device-code
Expand Down