Skip to content

Sarah/remove cdpx creds #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarahpeiffer merged 5 commits into from
Nov 2, 2021
Merged

Sarah/remove cdpx creds #685

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64e8d8e
use buildcommand for prod pipeline
sarahpeiffer Oct 8, 2021
4e9d66a
Merge branch 'ci_dev' of https://github.com/microsoft/Docker-Provider…
sarahpeiffer Oct 8, 2021
8bf6835
Merge branch 'ci_dev' of https://github.com/microsoft/Docker-Provider…
sarahpeiffer Oct 12, 2021
d16e40c
Merge branch 'ci_dev' of https://github.com/microsoft/Docker-Provider…
sarahpeiffer Nov 1, 2021
3d51603
remove download of cdpx creds
sarahpeiffer Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .pipelines/get-aad-app-creds-from-kv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ do
KV) KV=$VALUE ;;
KVSECRETNAMEAPPID) AppId=$VALUE ;;
KVSECRETNAMEAPPSECRET) AppSecret=$VALUE ;;
KVSECRETNAMECDPXAPPID) CdpxAppId=$VALUE ;;
KVSECRETNAMECDPXAPPSECRET) CdpxAppSecret=$VALUE ;;
*)
esac
done
Expand All @@ -29,16 +27,4 @@ az keyvault secret download --file ~/acrappsecret --vault-name ${KV} --name ${A

echo "downloaded the appsecret from KV:${KV} and KV secret:${AppSecret}"

echo "key vault secret name for cdpx appid:${KVSECRETNAMECDPXAPPID}"

echo "key vault secret name for cdpx appsecret:${KVSECRETNAMECDPXAPPSECRET}"

az keyvault secret download --file ~/cdpxacrappid --vault-name ${KV} --name ${CdpxAppId}

echo "downloaded the appid from KV:${KV} and KV secret:${CdpxAppId}"

az keyvault secret download --file ~/cdpxacrappsecret --vault-name ${KV} --name ${CdpxAppSecret}

echo "downloaded the appsecret from KV:${KV} and KV secret:${CdpxAppSecret}"

echo "end: get app id and secret from specified key vault"