Skip to content

Comments

Fix Set/Get DateTime Value in Form Header#753

Merged
TYLEROL merged 4 commits intomicrosoft:developfrom
AngelRodriguez8008:users/angel/fixSetDateTimeValue
Feb 7, 2020
Merged

Fix Set/Get DateTime Value in Form Header#753
TYLEROL merged 4 commits intomicrosoft:developfrom
AngelRodriguez8008:users/angel/fixSetDateTimeValue

Conversation

@AngelRodriguez8008
Copy link
Contributor

@AngelRodriguez8008 AngelRodriguez8008 commented Feb 7, 2020

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (updates to documentation, formatting, etc.)

Description

The values of the fields should get in the context where the control is.
See #719 for LookupItem this PR fix the same logic but for the DateTimeControl.

DONE: Get/SetHeaderValue for LookupItem / LookupItem[] / OptionSet
TODO: Get/SetHeaderValue for string / MultiValueOptionSet / BooleanItem

Issues addressed

Related to #719

All submissions:

  • My code follows the code style of this project.
  • Do existing samples that are effected by this change still run?
  • I have added samples for new functionality.
  • I raise detailed error messages when possible.
  • My code does not rely on labels that have the option to be hidden.

Which browsers was this tested on?

  • Chrome
  • Firefox
  • IE
  • Edge

@AngelRodriguez8008 AngelRodriguez8008 changed the title Fix Set Date/Time Value in Form Header Fix Set/Get DateTime Value in Form Header Feb 7, 2020
@AngelRodriguez8008
Copy link
Contributor Author

Sorry I did "unintentional" code reformat in one big file please review this PR ignoring whitespaces changes-
image

@TYLEROL TYLEROL added the bug label Feb 7, 2020
@TYLEROL TYLEROL added this to the 9.1.0.12013 milestone Feb 7, 2020
@TYLEROL TYLEROL linked an issue Feb 7, 2020 that may be closed by this pull request
12 tasks
@TYLEROL TYLEROL merged commit 1fba3d6 into microsoft:develop Feb 7, 2020
@AngelRodriguez8008 AngelRodriguez8008 deleted the users/angel/fixSetDateTimeValue branch February 7, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Unable to Get/SetHeaderValue for Owner

2 participants