Skip to content

[C#] RecordInfo v2 #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badrishc merged 8 commits into from
Oct 19, 2021
Merged

[C#] RecordInfo v2 #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b61d36a
RecordInfo v2
badrishc Oct 18, 2021
5c8622d
fix version jump in CPR.
badrishc Oct 18, 2021
e745ede
Updated misc stuff
badrishc Oct 19, 2021
3a06385
nit
badrishc Oct 19, 2021
f26bbe5
misc updates to SpanByte
badrishc Oct 19, 2021
a3309fe
Remove IntExclLocker
badrishc Oct 19, 2021
3e1bdb7
Add Try APIs to record locking
badrishc Oct 19, 2021
7079d5d
cleanup
badrishc Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cs/benchmark/FasterSpanByteYcsbBenchmark.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license.

#pragma warning disable CS0162 // Unreachable code detected -- when switching on YcsbConstants

// Define below to enable continuous performance report for dashboard
// #define DASHBOARD

Expand Down Expand Up @@ -297,7 +295,7 @@ internal unsafe (double, double) Run(TestLoader testLoader)
long start = swatch.ElapsedTicks;
if (store.TakeHybridLogCheckpoint(out _, testLoader.Options.PeriodicCheckpointType, testLoader.Options.PeriodicCheckpointTryIncremental))
{
store.CompleteCheckpointAsync().GetAwaiter().GetResult();
store.CompleteCheckpointAsync().AsTask().GetAwaiter().GetResult();
var timeTaken = (swatch.ElapsedTicks - start) / TimeSpan.TicksPerMillisecond;
Console.WriteLine("Checkpoint time: {0}ms", timeTaken);
checkpointTaken++;
Expand Down
4 changes: 1 addition & 3 deletions cs/benchmark/FasterYcsbBenchmark.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license.

#pragma warning disable CS0162 // Unreachable code detected -- when switching on YcsbConstants

// Define below to enable continuous performance report for dashboard
// #define DASHBOARD

Expand Down Expand Up @@ -292,7 +290,7 @@ internal unsafe (double, double) Run(TestLoader testLoader)
long start = swatch.ElapsedTicks;
if (store.TakeHybridLogCheckpoint(out _, testLoader.Options.PeriodicCheckpointType, testLoader.Options.PeriodicCheckpointTryIncremental))
{
store.CompleteCheckpointAsync().GetAwaiter().GetResult();
store.CompleteCheckpointAsync().AsTask().GetAwaiter().GetResult();
var timeTaken = (swatch.ElapsedTicks - start) / TimeSpan.TicksPerMillisecond;
Console.WriteLine("Checkpoint time: {0}ms", timeTaken);
checkpointTaken++;
Expand Down
10 changes: 8 additions & 2 deletions cs/benchmark/Functions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,18 @@ public void CopyUpdater(ref Key key, ref Input input, ref Value oldValue, ref Va

public void Lock(ref RecordInfo recordInfo, ref Key key, ref Value value, LockType lockType, ref long lockContext)
{
recordInfo.SpinLock();
if (lockType == LockType.Exclusive)
recordInfo.LockExclusive();
else
recordInfo.LockShared();
}

public bool Unlock(ref RecordInfo recordInfo, ref Key key, ref Value value, LockType lockType, long lockContext)
{
recordInfo.Unlock();
if (lockType == LockType.Exclusive)
recordInfo.UnlockExclusive();
else
recordInfo.UnlockShared();
return true;
}
}
Expand Down
Loading