Skip to content

Conversation

@Summpot
Copy link

@Summpot Summpot commented Apr 30, 2023

Fixes #717 because Microsoft.Extensions.Logging.Abstractions has very few dependencies.
#717 appears to have been fixed elsewhere, and now references to higher versions of Microsoft.Extensions.Logging.Abstractions work properly in the Microsoft.Azure.Functions.Worker.Sdk project.

@Summpot Summpot closed this Apr 30, 2023
@Summpot Summpot changed the title Use Microsoft.Extensions.Logging.Abstractions instead of Microsoft.Extensions.Logging to reduce dependencies and fix #717 by the way. Use Microsoft.Extensions.Logging.Abstractions instead of Microsoft.Extensions.Logging to reduce dependencies. May 1, 2023
…ted during packaging for SDK-style projects.
@Summpot Summpot reopened this May 1, 2023
@badrishc
Copy link
Collaborator

badrishc commented May 4, 2023

We need the .nuspec for our CI auto-release based on $version in there, so it should not be removed.

@Summpot
Copy link
Author

Summpot commented May 4, 2023

@badrishc But where are the related scripts?
I noticed that you create a tag in the format vx.x.x when releasing, so I think it would be a better choice to use GitVersion instead of this text template, which automatically reads the version on the tag and generates the corresponding AssemblyInfo.cs.

@badrishc
Copy link
Collaborator

We can look into whether using this instead of $version is possible in our internal release pipeline. But generally would rather not fix something that isn't broken.

@Summpot
Copy link
Author

Summpot commented Jun 4, 2023

The dotnet pack will now produce nuget packages with version 2.5.9+x. After you run git tag v2.5.9, it will produce nuget packages with version 2.5.9.
image

@Summpot Summpot closed this by deleting the head repository Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants