Conversation
Co-authored-by: Li Jiang <lijiang1@microsoft.com>
liususan091219
approved these changes
Mar 30, 2023
sonichi
reviewed
Apr 1, 2023
flaml/integrations/oai/completion.py
Outdated
| result_agg, responses_list, result_list = {}, [], [] | ||
| metric_keys = None | ||
| with diskcache.Cache(cls.cache_path) as cls._cache: | ||
| for _, data_i in enumerate(data): |
sonichi
reviewed
Apr 2, 2023
Contributor
sonichi
left a comment
sonichi
left a comment
There was a problem hiding this comment.
Finished a round of review.
notebook/integrate_chatgpt.ipynb
Outdated
Comment on lines
+1310
to
+1311
| "result = oai.Completion.test(test_data, config, success_metrics)\n", | ||
| "print('performance on test data with the tuned config:', result)" |
sonichi
reviewed
Apr 2, 2023
sonichi
approved these changes
Apr 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding a test function in the OpenAI completion such that we can directly evaluate the performance of an OpenAI model with a particular configuration.
Related issue number
Checks