use cmake presets instead of cmake settings #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonRadtke
added
Type: Enhancement
github-project-automation
bot
moved this to Open
in Microsoft/GSL Pull Requests In-Flight
carsonRadtke
moved this from Open
to Ready for Review
in Microsoft/GSL Pull Requests In-Flight
carsonRadtke
force-pushed
the
carsonradtke/add-cmake-presets
branch
from
9cee3da to
b14edaa
Compare
Member
Author
|
@copilot Can you update the GitHub Actions to make use of the presets? |
Contributor
|
@carsonRadtke I've opened a new pull request, #1223, to work on those changes. Once the pull request is ready, I'll request review from you. |
This change uses a cmake presets file in an effort allow for agentic AI to better switch between project settings. It replaces the old CMakeSettings.json for the more flexible CMakePresets.json.
* Initial plan * Update GitHub Actions to use CMake presets for compilers workflow Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>
carsonRadtke
force-pushed
the
carsonradtke/add-cmake-presets
branch
from
f67008e to
2214ecd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the build configuration by migrating from the Visual Studio-specific CMakeSettings.json to the more standardized and flexible CMakePresets.json format. This change improves cross-platform and cross-IDE support, particularly for agentic AI tooling that can now more easily switch between different build configurations.
Key Changes
- Introduces comprehensive CMakePresets.json with 24 configure presets covering all combinations of compilers (MSVC, GCC, Clang), C++ standards (14, 17, 20, 23), and build types (Debug, Release)
- Updates GitHub Actions workflows to use CMake presets instead of manual parameter passing
- Simplifies the cmake composite action by consolidating parameters into a single preset identifier
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeSettings.json | Removed legacy Visual Studio CMake settings file |
| CMakePresets.json | Added comprehensive preset definitions for all supported compiler/standard/build type combinations with proper inheritance hierarchy |
| .github/workflows/copilot-setup-steps.yml | Updated to use clang presets for C++14 and C++20 builds |
| .github/workflows/compilers.yml | Simplified workflow by replacing multiple parameters with preset names for gcc, clang, xcode, and MSVC jobs |
| .github/workflows/cmake/action.yml | Streamlined action inputs to use single preset parameter instead of multiple build configuration parameters |
gdr-at-ms
approved these changes
Dec 5, 2025
github-project-automation
bot
moved this from Ready for Review
to Approved
in Microsoft/GSL Pull Requests In-Flight
github-project-automation
bot
moved this from Approved
to Merged
in Microsoft/GSL Pull Requests In-Flight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses a cmake presets file in an effort allow for agentic AI to better switch between project settings. It replaces the old CMakeSettings.json for the more flexible CMakePresets.json.