Removing locale validation #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current locale validation doesn't support all cases, such as: de, zh-Hant-TW, En-au,aZ_cYrl-aZ The locale is validated in the WebChat app anyway so it's redundant.
barneaoren
approved these changes
Apr 7, 2020
amir-microsoft
added a commit
that referenced
this pull request
Jun 15, 2020
* Supporting Windows and Linux web apps. Linux by default (#57) * Supporting Windows and Linux web apps. Linux by default * bug fix * update readme * adding doc * update readme * Origin/deployment script update (#64) * Removing locale validation: (#63) Current locale validation doesn't support all cases, such as: de, zh-Hant-TW, En-au,aZ_cYrl-aZ The locale is validated in the WebChat app anyway so it's redundant. * Dynamic branch and repo for deploy (#70) * When using "deploy to azure" button, taking the repo and branch from the page where the button was clicked * Adding example for using Content security policy to limit which domains are allowed to embed this page as a frame * remove private preview from readme (#76) * remove private preview from readme * Description change Co-authored-by: Guy Becker <gubecker@microsoft.com> * Update index.html * Fixing a bug where a redundant parameters was passed to the function passed to Co-authored-by: Elad Iwanir <13205761+eladiw@users.noreply.github.com> Co-authored-by: GuyBeckerMicrosoft <61974899+GuyBeckerMicrosoft@users.noreply.github.com> Co-authored-by: Guy Becker <gubecker@microsoft.com> Co-authored-by: AdamWalkerMicrosoft <40535367+AdamWalkerMicrosoft@users.noreply.github.com> Co-authored-by: amir-microsoft <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing locale validation:
Current locale validation doesn't support all cases, such as: de, zh-Hant-TW, En-au,aZ_cYrl-aZ
The locale is validated in the WebChat app anyway so it's redundant.