replace % by %25 while building appcmd command#72
Open
erenes wants to merge 2 commits intomicrosoft:mainfrom
Open
replace % by %25 while building appcmd command#72erenes wants to merge 2 commits intomicrosoft:mainfrom
erenes wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Author
|
Unfortunately I cannot access the pipeline log, so can't resolve whatever error happens there. If anyone has any idea I am happy to update my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #71, verified on my own windows 2019 image and 2016ltsc image.
Assuming the % escaping behavior is not version-specific for appcmd.exe (unfortunately this is not verifiable for me), I think this fix is relatively safe.