Skip to content

[docs] update usage information#86

Closed
profnandaa wants to merge 1 commit intomicrosoft:mainfrom
profnandaa:patch-1
Closed

[docs] update usage information#86
profnandaa wants to merge 1 commit intomicrosoft:mainfrom
profnandaa:patch-1

Conversation

@profnandaa
Copy link

No description provided.

@profnandaa profnandaa requested a review from a team as a code owner December 5, 2022 09:52
goto Finished;
}

//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is about environment variables being updated and that behavior being hardcoded.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, will revert that...

@mloskot
Copy link

mloskot commented Nov 7, 2024

Folks, can this trivial update be merged?

Users currently have no way to learn about the features. Unless, they can read C++ code:

WCHAR* pstrAppPoolName = L"DefaultAppPool";
if (argc > 2)
{
pstrAppPoolName = argv[2];
}
IISConfigUtil configHelper = IISConfigUtil();
if( FAILED(hr = configHelper.Initialize()) ||
FAILED(hr = configHelper.UpdateEnvironmentVarsToConfig(pstrAppPoolName)))

and this note is quite essential to leak it into docs too:

// iis scenario, update the environment variable

as there are users, including myself, who use the ServiceMonitor to wrap other services than w3svc :)

@sujitnayak
Copy link
Member

@profnandaa do you need anything else to go ahead with the merge?

@profnandaa
Copy link
Author

@sujitnayak -- merge rights; I have limited access to the repo.

@sujitnayak
Copy link
Member

@profnandaa Do you see any way to trigger the license/cla check? It looks like it's blocking the merge since it hasn't run yet.

@profnandaa
Copy link
Author

Let me re-open.

@profnandaa profnandaa closed this Nov 13, 2024
@profnandaa profnandaa reopened this Nov 13, 2024
@profnandaa profnandaa closed this Nov 13, 2024
profnandaa added a commit to profnandaa/IIS.ServiceMonitor that referenced this pull request Nov 13, 2024
Add another way of starting up providing the _application pool name_.

NOTE: re-openning microsoft#86 due to CLA check, I think I opened the PR
back in the days  before I had signed the CLA.

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
@profnandaa
Copy link
Author

Re-opened here - #91 @sujitnayak

@profnandaa profnandaa deleted the patch-1 branch November 13, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants