-
Notifications
You must be signed in to change notification settings - Fork 0
Add GitHub Actions build workflow and migrate DecodeTest to .NET 10.0 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Robo210 <1312684+Robo210@users.noreply.github.com>
Co-authored-by: Robo210 <1312684+Robo210@users.noreply.github.com>
|
@copilot retarget the .netcore 3.1 projects to .net 8 |
Co-authored-by: Robo210 <1312684+Robo210@users.noreply.github.com>
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <TargetFrameworks>net6.0;net8.0;net10.0</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idigdoug if this is targeting net6, and this is the "main" library for using tracepoints, what is the point of having the other libraries target netstandard21? They aren't super useful on their own, and nobody is going to use, e.g., the Types library in a .net core 3.1 app because that went out of support years before this was written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we standardize on net6.0 as the lowest version to support in the nuget packages, nobody will be impacted. And once we want to make a bigger version number bump, we could drop net6 (already EOL for many years) for net8 (which itself will be EOL this year).
I'm not proposing to drop netstandard21 in this PR, but I think a subsequent one could safely do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(yes, I know the Types dll doesn't have any meaningful code in it and could work with truly ancient .net versions, but building it for netstandard21 seems like an academic exercise and not practically useful in 2026)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how important it is, but the decoding support works with netstandard, and decoding is used by things like WPA. I don't remember what WPA targets.
| <Pack>True</Pack> | ||
| <PackagePath>\</PackagePath> | ||
| </None> | ||
| <None Include="README.md" Pack="true" PackagePath=""/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason nuget was unhappy with the prior syntax for this package (the rest were fine). I couldn't make it happy, so I just switched to this alternative syntax and now everything works.
dotnet testsupport is highly improved in .NET 10, so build using the 10 SDK